Repository navigation
feat(bedrock): Add extension skeleton - #8226
Open
alexander-alderman-webb wants to merge 1 commit into
Open
alexander-alderman-webb wants to merge 1 commit into
alexander-alderman-webb wants to merge 1 commit into
Conversation
alexander-alderman-webb
force-pushed
the
webb/bedrock/skeleton
branch
4 times, most recently
from
November 9, 2026 09:37
819486b to
3fc87ab
Compare
alexander-alderman-webb
marked this pull request as ready for review
November 9, 2026 09:41
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Coverage Results 📊✅ 137255 passed | ⏭️ 7569 skipped | Total: 144824 | Pass Rate: 94.77% | Execution Time: 468m 7s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 91.18% (31 of 34 changed executable lines covered; target 80%). Changed files with executable lines (4)
Coverage diff@@ Coverage Diff @@
## master #8226 +/-##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 203 203 —
Tracked lines 26933 26946 +13
Branches 10058 10064 +6
==========================================
+ Hits 24321 24331 +10
- Misses 2612 2615 +3
- Partials 1518 1519 +1Generated by Coverage Action |
alexander-alderman-webb
force-pushed
the
webb/bedrock/skeleton
branch
from
November 9, 2026 09:51
3fc87ab to
d6cde74
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6cde74. Configure here.
alexander-alderman-webb
marked this pull request as draft
November 9, 2026 09:54
alexander-alderman-webb
force-pushed
the
webb/bedrock/skeleton
branch
from
November 9, 2026 10:04
d6cde74 to
0099e3e
Compare
alexander-alderman-webb
marked this pull request as ready for review
November 9, 2026 10:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a basic bedrock extension that sets the
gen_ai.operation.name,gen_ai.provider.nameandgen_ai.response.streamingattributes.This is the first boto3 extension. I've cleaned up some things:
registry.py. We control all extensions in the SDK, so this indirection seems unnecessary.test_bedrock.pyso the relevant behavior is still exercised.capture_internal_exceptions()around invocations of extension functions. If there's code that can raise in the extensions, the extensions can wrap the relevant lines themselves.skip_if_no_active_spanboolean so that Bedrock spans are created even when there is no active span, matching the behavior of other chat integrations.